[webkit-reviews] review denied: [Bug 223881] Style checker should warn about use of future OS versions in WK_API_AVAILABLE : [Attachment 424606] Patch v1.0

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has denied BJ Burg <bburg at apple.com>'s
request for review:
Bug 223881: Style checker should warn about use of future OS versions in
WK_API_AVAILABLE
https://bugs.webkit.org/show_bug.cgi?id=223881

Attachment 424606: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=424606&action=review




--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 424606
  --> https://bugs.webkit.org/attachment.cgi?id=424606
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=424606&action=review

> Tools/Scripts/webkitpy/style/checkers/cpp.py:3309
> +    MAX_ALLOWED_MACOS_VERSION = 11.0

We have these hard-coded in Tools/Scripts/webkitpy/common/version_name_map.py,
we're trying to centralize versions for this sort of thing in that file