[webkit-reviews] review granted: [Bug 223856] Merge DOMWindow+IndexedDatabase.idl and WorkerGlobalScope+IndexedDatabase.idl into a single WindowOrWorkerGlobalScope+IndexedDatabase.idl to match the IndexedDB spec : [Attachment 424518] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 29 17:17:46 PDT 2021


Sihui Liu <sihui_liu at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 223856: Merge DOMWindow+IndexedDatabase.idl and
WorkerGlobalScope+IndexedDatabase.idl into a single
WindowOrWorkerGlobalScope+IndexedDatabase.idl to match the IndexedDB spec
https://bugs.webkit.org/show_bug.cgi?id=223856

Attachment 424518: Patch

https://bugs.webkit.org/attachment.cgi?id=424518&action=review




--- Comment #2 from Sihui Liu <sihui_liu at apple.com> ---
Comment on attachment 424518
  --> https://bugs.webkit.org/attachment.cgi?id=424518
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424518&action=review

>
Source/WebCore/Modules/indexeddb/WindowOrWorkerGlobalScopeIndexedDatabase.cpp:3
3
> +#include "DatabaseProvider.h"

Is this needed?

>
Source/WebCore/Modules/indexeddb/WindowOrWorkerGlobalScopeIndexedDatabase.cpp:3
7
> +#include "IDBOpenDBRequest.h"

Is this needed?

>
Source/WebCore/Modules/indexeddb/WindowOrWorkerGlobalScopeIndexedDatabase.cpp:3
9
> +#include "ScriptExecutionContext.h"

Is this needed?


More information about the webkit-reviews mailing list