[webkit-reviews] review granted: [Bug 223890] [ews] Add build step to find list of layout tests modified by a patch : [Attachment 424578] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 223890: [ews] Add build step to find list of layout tests modified by a
patch
https://bugs.webkit.org/show_bug.cgi?id=223890

Attachment 424578: Patch

https://bugs.webkit.org/attachment.cgi?id=424578&action=review




--- Comment #4 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 424578
  --> https://bugs.webkit.org/attachment.cgi?id=424578
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424578&action=review

Aakash wants to get this running in production and add additional extensions in
a later patch

> Tools/CISupport/ews-build/steps.py:463
> +    RE_LAYOUT_TEST = b'^(\+\+\+).*(LayoutTests.*.html)'

I think this might should be:
    b'^(\+\+\+).* LayoutTests/(.*.html)'
although we might want to save that change for later, since based on some of
the staging instance behavior, that may end up changing the behavior of skipped
tests.

> Tools/CISupport/ews-build/steps.py:472
> +		   if any((suffix + '.html').encode('utf-8') in line for suffix
in self.SUFFIXES_TO_IGNORE):

We probably don't actually need to add .html here, although that will be more
relevant when more extensions are added.