[webkit-reviews] review granted: [Bug 223864] [GPU Process] Don't record DisplayList items if the GPU Process has been terminated : [Attachment 424526] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 29 14:43:27 PDT 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 223864: [GPU Process] Don't record DisplayList items if the GPU Process has
been terminated
https://bugs.webkit.org/show_bug.cgi?id=223864

Attachment 424526: Patch

https://bugs.webkit.org/attachment.cgi?id=424526&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 424526
  --> https://bugs.webkit.org/attachment.cgi?id=424526
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424526&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h:68
> -	   virtual void willAppendItemOfType(ItemType) { }
> +	   virtual bool canAppendItemOfType(ItemType) { return false; }

What is the caller supposed to do with the return value?


More information about the webkit-reviews mailing list