[webkit-reviews] review denied: [Bug 223890] [ews] Add build step to find list of layout tests modified by a patch : [Attachment 424556] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has denied Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 223890: [ews] Add build step to find list of layout tests modified by a
patch
https://bugs.webkit.org/show_bug.cgi?id=223890

Attachment 424556: Patch

https://bugs.webkit.org/attachment.cgi?id=424556&action=review




--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 424556
  --> https://bugs.webkit.org/attachment.cgi?id=424556
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424556&action=review

If we want EWS to own this task without running run-webkit-tests (which is a
reasonable requirement), look through layout_test_finder.py to make sure we
duplicate all of the required logic.

> Tools/CISupport/ews-build/steps.py:463
> +    RE_LAYOUT_TEST = b'^(\+\+\+).*(LayoutTests.*.html)'

The logic for determining what is and is not a layout test are more complicated
than this. Layout tests can be the following extensions (as per
layout_test_finder.py):
    '.html', '.shtml', '.xml', '.xhtml', '.pl', '.py', '.htm', '.php', '.svg',
'.mht', '.xht'
We also need exclude the following directories:
    'resources', 'support', 'script-tests', 'tools', 'reference', 'reftest'

> Tools/CISupport/ews-build/steps.py:469
> +	       if match and (b'-expected.html' not in line):

Suffix exclusions include:
    '-expected', '-expected-mismatch', '-ref', '-notref'