[webkit-reviews] review granted: [Bug 223262] [resultsdbpy] Return new-style commits : [Attachment 424554] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 223262: [resultsdbpy] Return new-style commits
https://bugs.webkit.org/show_bug.cgi?id=223262

Attachment 424554: Patch

https://bugs.webkit.org/attachment.cgi?id=424554&action=review




--- Comment #5 from dewei_zhu at apple.com ---
Comment on attachment 424554
  --> https://bugs.webkit.org/attachment.cgi?id=424554
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424554&action=review

r=me

>
Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/commit_controller.py
:32
> +    if bool(ref) + bool(uuid) + bool(timestamp) > 1:

Is this equivalent to `any([ref, uuid, timestamp])`?

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:-26
> -from datetime import datetime

Why do we defer the import here?