[webkit-reviews] review granted: [Bug 223883] Remove [Replaceable] extended attribute from `document.all` : [Attachment 424543] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 223883: Remove [Replaceable] extended attribute from `document.all`
https://bugs.webkit.org/show_bug.cgi?id=223883

Attachment 424543: Patch

https://bugs.webkit.org/attachment.cgi?id=424543&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 424543
  --> https://bugs.webkit.org/attachment.cgi?id=424543
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424543&action=review

> Source/WebCore/ChangeLog:13
> +	   iOS apps should be unaffected as they were authored long after
`document.all` time.

What you mean is:

- iOS apps are unlikely to accidentally depend on subtleties in document.all
behavior since they were authored long after there was a need,

But this ignores the likelihood that these apps may include very old versions
of libraries originally designed for the web. I am optimistic this will not be
the case, but I don’t know that we can confidently state that.