[webkit-reviews] review granted: [Bug 176131] Compile WebKit with UBSan : [Attachment 424475] Patch v2

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 176131: Compile WebKit with UBSan
https://bugs.webkit.org/show_bug.cgi?id=176131

Attachment 424475: Patch v2

https://bugs.webkit.org/attachment.cgi?id=424475&action=review




--- Comment #17 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 424475
  --> https://bugs.webkit.org/attachment.cgi?id=424475
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=424475&action=review

> Source/bmalloc/bmalloc/Environment.cpp:113
> +	       if (!strncmp(sanitizerName, ubsanName, sizeof(ubsanName) - 1))
> +		   return true;

I know that this function is named isSanitizerEnabled, but do we actually need
or want to disable bmalloc for UBSan?

> Tools/sanitizer/ubsan.xcconfig:7
> +WK_ENABLE_SANITIZER = $(ENABLE_UNDEFINED_BEHAVIOR_SANITIZER);

Does this allow for combining ASan and UBSan?

> Tools/sanitizer/ubsan.xcconfig:11
> +WK_SANITIZER_OTHER_CFLAGS_YES = $(inherited) -fno-delete-null-pointer-checks
-fno-optimize-sibling-calls -fno-sanitize=vptr;

It would be useful to have explanations of why these are needed:
-fno-delete-null-pointer-checks -fno-optimize-sibling-calls.