[webkit-reviews] review granted: [Bug 222897] [perf dashboard] Add commit revision label support : [Attachment 424442] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 27 03:48:48 PDT 2021

Ryosuke Niwa <rniwa at webkit.org> has granted Zhifei Fang
<zhifei_fang at apple.com>'s request for review:
Bug 222897: [perf dashboard] Add commit revision label support

Attachment 424442: Patch


--- Comment #56 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 424442
  --> https://bugs.webkit.org/attachment.cgi?id=424442

View in context: https://bugs.webkit.org/attachment.cgi?id=424442&action=review

r=me but it seems like this patch needs be updated for ToT revision?

> Websites/perf.webkit.org/public/v3/models/commit-log.js:61
> +	       return 'git';
>      }

Again, we should return null here.

> Websites/perf.webkit.org/server-tests/api-report-tests.js:394
> +	   for (let repository of repositories)

Nit: const.

> Websites/perf.webkit.org/server-tests/api-report-tests.js:398
> +	   for (let commit of commits)

Nit: const.

More information about the webkit-reviews mailing list