[webkit-reviews] review granted: [Bug 223826] REGRESSION (r275038?): Perf test IndexedDB/stress/large-binary-keys.html failing with logging about memory pressure events : [Attachment 424418] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 26 17:40:39 PDT 2021


Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 223826: REGRESSION (r275038?): Perf test
IndexedDB/stress/large-binary-keys.html failing with logging about memory
pressure events
https://bugs.webkit.org/show_bug.cgi?id=223826

Attachment 424418: Patch

https://bugs.webkit.org/attachment.cgi?id=424418&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 424418
  --> https://bugs.webkit.org/attachment.cgi?id=424418
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424418&action=review

> Source/WTF/ChangeLog:10
> +	   Use RELEASE_LOG() instead of WTFLogAlways() to log memory pressure
events, so that they don't
> +	   show on stdout in the performance tests and make them fail.

Does this still achieve what we want in production builds?


More information about the webkit-reviews mailing list