[webkit-reviews] review granted: [Bug 223823] WebFeature class fails to copy/retain its instance variables : [Attachment 424412] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 26 17:27:04 PDT 2021
Sam Weinig <sam at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 223823: WebFeature class fails to copy/retain its instance variables
https://bugs.webkit.org/show_bug.cgi?id=223823
Attachment 424412: Patch v1
https://bugs.webkit.org/attachment.cgi?id=424412&action=review
--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 424412
--> https://bugs.webkit.org/attachment.cgi?id=424412
Patch v1
I think Chris is trying to use RetainPtr everywhere, so we probably should here
too, but you don't have to in this patch. I can do so in a follow up.
More information about the webkit-reviews
mailing list