[webkit-reviews] review granted: [Bug 223820] [webkit-patch] Use commit.webkit.org instead of remote SVN to compute identifier : [Attachment 424406] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 223820: [webkit-patch] Use commit.webkit.org instead of remote SVN to
compute identifier
https://bugs.webkit.org/show_bug.cgi?id=223820

Attachment 424406: Patch

https://bugs.webkit.org/attachment.cgi?id=424406&action=review




--- Comment #3 from dewei_zhu at apple.com ---
Comment on attachment 424406
  --> https://bugs.webkit.org/attachment.cgi?id=424406
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424406&action=review

> Tools/Scripts/webkitpy/tool/comments.py:42
> +    repr = 'r{}'.format(svn_revision)
> +    response =
requests.get('https://commits.webkit.org/{}/json'.format(repr))
> +    if response.status_code == 200:
> +	   repr = response.json().get('identifier', repr)
> +    return 'Committed r{} ({}): <{}>'.format(svn_revision, repr if '@' in
repr else '?', urls.view_identifier_url(repr))

Should we consider using svn.webkit.org as a fallback just in case the former
is down?