[webkit-reviews] review granted: [Bug 223696] Source/WebCore/editing/cocoa/HTMLConverter.mm:1278:44: runtime error: member call on null pointer of type 'WebCore::ArchiveResource' : [Attachment 424145] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 26 13:40:28 PDT 2021


Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 223696: Source/WebCore/editing/cocoa/HTMLConverter.mm:1278:44: runtime
error: member call on null pointer of type 'WebCore::ArchiveResource'
https://bugs.webkit.org/show_bug.cgi?id=223696

Attachment 424145: Patch

https://bugs.webkit.org/attachment.cgi?id=424145&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 424145
  --> https://bugs.webkit.org/attachment.cgi?id=424145
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424145&action=review

> Source/WebCore/editing/cocoa/HTMLConverter.mm:-1278
> -	   const String& mimeType = resource->mimeType();

basically just null checking resource here.


More information about the webkit-reviews mailing list