[webkit-reviews] review granted: [Bug 223781] Allow some image overlay content to render in fully transparent image elements : [Attachment 424356] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 223781: Allow some image overlay content to render in fully transparent
image elements
https://bugs.webkit.org/show_bug.cgi?id=223781

Attachment 424356: Patch

https://bugs.webkit.org/attachment.cgi?id=424356&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 424356
  --> https://bugs.webkit.org/attachment.cgi?id=424356
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424356&action=review

> Source/WebCore/page/ImageOverlayController.cpp:86
> +	   if (overlayHostRenderer->style().opacity() > 0.01)
> +	       return nullptr;

This is sneakily hidden, and I almost missed it. Maybe possible to make it
obvious that this is all inert in the "normal" case?