[webkit-reviews] review granted: [Bug 223568] CSS transitions on object-position don't work : [Attachment 424367] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at webkit.org> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 223568: CSS transitions on object-position don't work
https://bugs.webkit.org/show_bug.cgi?id=223568

Attachment 424367: Patch

https://bugs.webkit.org/attachment.cgi?id=424367&action=review




--- Comment #8 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 424367
  --> https://bugs.webkit.org/attachment.cgi?id=424367
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424367&action=review

> Source/WebCore/animation/CSSPropertyAnimation.cpp:773
> +static bool canInterpolateLengthPoints(const LengthPoint& from, const
LengthPoint& to)
> +{
> +    bool isLengthPercentage = true;
> +    return canInterpolateLengths(from.x(), to.x(), isLengthPercentage)
> +	   && canInterpolateLengths(from.y(), to.y(), isLengthPercentage);
> +}

I think you can put this logic straight in the canInterpolate() override. That
said, maybe this can simply be ommitted, or are there cases where the values
cannot be interpolated? The WPT test doesn't test any case where interpolation
between two valid values doesn't happen.