[webkit-reviews] review granted: [Bug 223661] PCM: Rename attributeOn to attributionDestination and change the IDL data type of attributionSourceId to unsigned long : [Attachment 424094] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 223661: PCM: Rename attributeOn to attributionDestination and change the
IDL data type of attributionSourceId to unsigned long
https://bugs.webkit.org/show_bug.cgi?id=223661

Attachment 424094: Patch

https://bugs.webkit.org/attachment.cgi?id=424094&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 424094
  --> https://bugs.webkit.org/attachment.cgi?id=424094
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424094&action=review

r=me

>
LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-validation
-expected.txt:8
> +CONSOLE MESSAGE: Both attributionsourceid and attributiondestination need to
be set for Private Click Measurement to work.

It's interesting that your renaming change seems to have affected the number
and order of these messages. Is that expected?
Update: I guess this is a by-product of changing from string to number, and
removing some test cases below.