[webkit-reviews] review granted: [Bug 223069] REGRESSION(r271560): [Linux] release assert in Thread::initializePlatformThreading : [Attachment 424233] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 25 04:36:20 PDT 2021


Carlos Garcia Campos <cgarcia at igalia.com> has granted Alberto Garcia
<berto at igalia.com>'s request for review:
Bug 223069: REGRESSION(r271560): [Linux] release assert in
Thread::initializePlatformThreading
https://bugs.webkit.org/show_bug.cgi?id=223069

Attachment 424233: Patch

https://bugs.webkit.org/attachment.cgi?id=424233&action=review




--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 424233
  --> https://bugs.webkit.org/attachment.cgi?id=424233
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424233&action=review

> Source/WTF/wtf/posix/ThreadingPOSIX.cpp:213
> +	       WTFLogAlways("Overriding existing handler for signal %d. "
> +		   "Set JSC_SIGNAL_FOR_GC if you want WebKit to use a different
signal", signal);

I would use a single line even if it's a bit long.


More information about the webkit-reviews mailing list