[webkit-reviews] review granted: [Bug 223728] WKContentRuleList first-party should include other subdomains of the current registrable domain : [Attachment 424215] Patch

[bugzilla-daemon at webkit.org]

John Wilander <wilander at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 223728: WKContentRuleList first-party should include other subdomains of
the current registrable domain
https://bugs.webkit.org/show_bug.cgi?id=223728

Attachment 424215: Patch

https://bugs.webkit.org/attachment.cgi?id=424215&action=review




--- Comment #3 from John Wilander <wilander at apple.com> ---
Comment on attachment 424215
  --> https://bugs.webkit.org/attachment.cgi?id=424215
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424215&action=review

r=me with a requested change.

> Source/WebCore/loader/ResourceLoadInfo.cpp:131
> +    return RegistrableDomain(mainDocumentURL) !=
RegistrableDomain(resourceURL);

You should be able to use RegistrableDomain::matches(const URL& url) here which
is faster than creating two RegistrableDomain objects.