[webkit-reviews] review granted: [Bug 223677] Autoinstalling keyring-7.3.1 is failing with Python 2 : [Attachment 424178] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 24 16:08:04 PDT 2021


dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 223677: Autoinstalling keyring-7.3.1 is failing with Python 2
https://bugs.webkit.org/show_bug.cgi?id=223677

Attachment 424178: Patch

https://bugs.webkit.org/attachment.cgi?id=424178&action=review




--- Comment #9 from dewei_zhu at apple.com ---
Comment on attachment 424178
  --> https://bugs.webkit.org/attachment.cgi?id=424178
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424178&action=review

r=me with comment.

> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:235
>	   # Make sure that setuptools and wheel are installed, since setup.py
relies on it

We may want to update the comment here as well.


More information about the webkit-reviews mailing list