[webkit-reviews] review granted: [Bug 223028] SendKeys on Input of type=file returns element not found in some cases : [Attachment 423968] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 24 15:03:43 PDT 2021


Devin Rousso <drousso at apple.com> has granted BJ Burg <bburg at apple.com>'s
request for review:
Bug 223028: SendKeys on Input of type=file returns element not found in some
cases
https://bugs.webkit.org/show_bug.cgi?id=223028

Attachment 423968: Patch

https://bugs.webkit.org/attachment.cgi?id=423968&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 423968
  --> https://bugs.webkit.org/attachment.cgi?id=423968
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423968&action=review

r=me :)

> Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:938
> +    Ref<JSON::ArrayOf<String>> selectedFiles =
JSON::ArrayOf<String>::create();
> +    for (const String& filename : m_filesToSelectForFileUpload)

NIT: `auto`?


More information about the webkit-reviews mailing list