[webkit-reviews] review denied: [Bug 223706] Allow logging minimal info about uploading media files in the system diagnose : [Attachment 424171] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 24 13:46:43 PDT 2021
Alex Christensen <achristensen at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 223706: Allow logging minimal info about uploading media files in the
system diagnose
https://bugs.webkit.org/show_bug.cgi?id=223706
Attachment 424171: Patch
https://bugs.webkit.org/attachment.cgi?id=424171&action=review
--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 424171
--> https://bugs.webkit.org/attachment.cgi?id=424171
Patch
Let's not add to the C API. If someone is using the C API that needs to get
this new message, they need to migrate to the ObjC API.
I'm also not sure if we need to add LogDiagnosticMessageWithDomain. Can one of
the other logging methods do?
More information about the webkit-reviews
mailing list