[webkit-reviews] review granted: [Bug 221972] Web Inspector: Grid layout labels can be drawn outside the viewport : [Attachment 424146] Patch v1.1 - Added `USE(CG)` check

[bugzilla-daemon at webkit.org]

BJ Burg <bburg at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 221972: Web Inspector: Grid layout labels can be drawn outside the viewport
https://bugs.webkit.org/show_bug.cgi?id=221972

Attachment 424146: Patch v1.1 - Added `USE(CG)` check

https://bugs.webkit.org/attachment.cgi?id=424146&action=review




--- Comment #7 from BJ Burg <bburg at apple.com> ---
Comment on attachment 424146
  --> https://bugs.webkit.org/attachment.cgi?id=424146
Patch v1.1 - Added `USE(CG)` check

View in context: https://bugs.webkit.org/attachment.cgi?id=424146&action=review

r=me, great stuff!

> Source/WebKit/ChangeLog:8
> +	   Add support the new
`WebCore::InspectorOverlay::LabelArrowEdgePosition` property to grid overlays
on iOS.

Nit: add support *for*

> Source/WebKit/UIProcess/Inspector/ios/WKInspectorHighlightView.mm:411
> +    auto labelWebCorePath =
WebCore::InspectorOverlay::backgroundPathForLayoutLabel(textWidth + (padding *
2), textHeight + (padding * 2), arrowDirection, arrowEdgePosition, arrowSize);

I would name this labelPath, and the existing labelPath as platformLabelPath