[webkit-reviews] review granted: [Bug 223701] Silence UBSan warning in FontDescriptionKey::computeHash() : [Attachment 424155] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 223701: Silence UBSan warning in FontDescriptionKey::computeHash()
https://bugs.webkit.org/show_bug.cgi?id=223701

Attachment 424155: Patch

https://bugs.webkit.org/attachment.cgi?id=424155&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 424155
  --> https://bugs.webkit.org/attachment.cgi?id=424155
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424155&action=review

> Source/WebCore/platform/graphics/FontCache.h:109
> +    NO_SANITIZE("undefined") inline unsigned computeHash() const

I guess this is OK, because IntegerHasher is deprecated and our stated
direction is to move to Hasher instead.

If IntegerHasher was not deprecated, I would say that instead we need to do
more overloading of the add function in IntegerHasher rather than writing
NO_SANITIZE.

Maybe we should port this function to use Hasher instead?