[webkit-reviews] review granted: [Bug 223697] Source/WebCore/page/FrameView.h:990:50: runtime error: signed integer overflow: 65537 * 65537 cannot be represented in type 'int' : [Attachment 424150] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 223697: Source/WebCore/page/FrameView.h:990:50: runtime error: signed
integer overflow: 65537 * 65537 cannot be represented in type 'int'
https://bugs.webkit.org/show_bug.cgi?id=223697

Attachment 424150: Patch

https://bugs.webkit.org/attachment.cgi?id=424150&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 424150
  --> https://bugs.webkit.org/attachment.cgi?id=424150
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424150&action=review

> Source/WebCore/ChangeLog:13
> +	   - Source/WebCore/page/FrameView.h:990:50: runtime error: signed
integer overflow: -33554432 * -33554432 cannot be represented in type 'int'

Surprised that we are computing area of sizes that have negative width or
height.

> Source/WebCore/page/FrameView.h:994
> +    if (UNLIKELY(area.hasOverflowed()))

Makes me wish Checked had a "saturation" mode so we didn’t have to write such
extensive code.