[webkit-reviews] review granted: [Bug 202538] [WebRTC][GStreamer] Build and use the openh264 based encoder if present on the system : [Attachment 422244] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 202538: [WebRTC][GStreamer] Build and use the openh264 based encoder if
present on the system
https://bugs.webkit.org/show_bug.cgi?id=202538

Attachment 422244: Patch

https://bugs.webkit.org/attachment.cgi?id=422244&action=review




--- Comment #15 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 422244
  --> https://bugs.webkit.org/attachment.cgi?id=422244
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422244&action=review

>
Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
456
> +	   GST_DEBUG("Using OpenH264 libwebrtc encoder.");
> +#if WEBKIT_LIBWEBRTC_OPENH264_ENCODER

Shouldn't these two lines be swapped? Maybe adding another one for the
GStreamer encoder? And maybe INFO rather than just debug.