[webkit-reviews] review granted: [Bug 223657] [Cocoa] Revise loadSimulatedRequest API with final review comments : [Attachment 424076] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 223657: [Cocoa] Revise loadSimulatedRequest API with final review comments
https://bugs.webkit.org/show_bug.cgi?id=223657

Attachment 424076: Patch

https://bugs.webkit.org/attachment.cgi?id=424076&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 424076
  --> https://bugs.webkit.org/attachment.cgi?id=424076
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424076&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:492
> +- (WKNavigation *)loadSimulatedRequest:(NSURLRequest *)request
response:(NSURLResponse *)response responseData:(NSData *)data
WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

Nobody suggested responseBody instead of responseData?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm:54
> +    [delegate waitForDidFinishNavigation];

This should do more than just wait until navigation finishes.  It should verify
that the data did load how we think it should.