[webkit-reviews] review granted: [Bug 223649] Don't require VM_FLAGS_PERMANENT on the simulator builds : [Attachment 424048] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 223649: Don't require VM_FLAGS_PERMANENT on the simulator builds
https://bugs.webkit.org/show_bug.cgi?id=223649

Attachment 424048: patch

https://bugs.webkit.org/attachment.cgi?id=424048&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 424048
  --> https://bugs.webkit.org/attachment.cgi?id=424048
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424048&action=review

> Source/WTF/wtf/WTFConfig.cpp:80
> +#if HAVE(VM_FLAGS_PERMANENT) && PLATFORM(IOS_FAMILY_SIMULATOR)

I'd add FIXME: Remove the fallback when the oldest host OS that we support for
Simulator has VM_FLAGS_PERMANENT.

> Source/WTF/wtf/WTFConfig.cpp:82
> +	       flags = VM_FLAGS_FIXED | VM_FLAGS_OVERWRITE;

It should be safer against potential future code modifications to clear
VM_FLAGS_PERMANENT here, not to double-guess what it was set to ten lines
above.