[webkit-reviews] review granted: [Bug 223208] [iOS][FCR] Add pressed state for button-like controls : [Attachment 423759] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 23 10:57:43 PDT 2021
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 223208: [iOS][FCR] Add pressed state for button-like controls
https://bugs.webkit.org/show_bug.cgi?id=223208
Attachment 423759: Patch
https://bugs.webkit.org/attachment.cgi?id=423759&action=review
--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 423759
--> https://bugs.webkit.org/attachment.cgi?id=423759
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=423759&action=review
> Source/WebCore/rendering/RenderThemeIOS.mm:2100
> + if (!(states & ControlStates::EnabledState))
ControlStates::States should be an enum class, and be used OptionSet<>
More information about the webkit-reviews
mailing list