[webkit-reviews] review granted: [Bug 223547] Provide a way to specify platform vs security key when requesting an assertion in the SPI : [Attachment 423994] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 223547: Provide a way to specify platform vs security key when requesting
an assertion in the SPI
https://bugs.webkit.org/show_bug.cgi?id=223547

Attachment 423994: Patch

https://bugs.webkit.org/attachment.cgi?id=423994&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 423994
  --> https://bugs.webkit.org/attachment.cgi?id=423994
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423994&action=review

r=me

> Source/WebCore/ChangeLog:5
> +	   rdar://74034746

nit: <rdar://74034746>

> Source/WebCore/ChangeLog:15
> +	   * Modules/webauthn/AuthenticatorAttachment.idl: Copied from
Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm.

I would say these two were "Moved from ...."

> Source/WebKit/ChangeLog:5
> +	   rdar://74034746

Ditto

> Source/WebKit/ChangeLog:12
> +	   * UIProcess/API/Cocoa/_WKAuthenticatorAttachment.h: Copied from
Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm.

Ditto "Moved from ..."