[webkit-reviews] review granted: [Bug 222635] Service worker loads are not marked as app-bound : [Attachment 423238] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 23 09:43:33 PDT 2021


youenn fablet <youennf at gmail.com> has granted katherine_cheney at apple.com's
request for review:
Bug 222635: Service worker loads are not marked as app-bound
https://bugs.webkit.org/show_bug.cgi?id=222635

Attachment 423238: Patch

https://bugs.webkit.org/attachment.cgi?id=423238&action=review




--- Comment #14 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 423238
  --> https://bugs.webkit.org/attachment.cgi?id=423238
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423238&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:1639
> +    [webView _appBoundNavigationData: ^(struct
WKAppBoundNavigationTestingData data) {

Could we do that check before reloading as well.
Is there a way to clear the appBoundNavigationData as well?
I would guess that for synthetic data, in the reload case, we would probably
not see any load at all from the web page.


More information about the webkit-reviews mailing list