[webkit-reviews] review denied: [Bug 222888] [GStreamer] CaptureDevice monitor used from UIProcess : [Attachment 424017] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 222888: [GStreamer] CaptureDevice monitor used from UIProcess
https://bugs.webkit.org/show_bug.cgi?id=222888

Attachment 424017: Patch

https://bugs.webkit.org/attachment.cgi?id=424017&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 424017
  --> https://bugs.webkit.org/attachment.cgi?id=424017
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424017&action=review

> Source/WebKit/ChangeLog:8
> +	   GStreamer ports aim to reduce usage of the GStreamer library in the
UIProcess and thus

Why are you doing this?  Our view is that the web process is untrusted so we
moved capturing things like this to the trusted UI process.

>
Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:163
> +   
WebCore::RealtimeMediaSourceCenter::singleton().getMediaStreamDevices([this,
shouldNotify] (auto&& newDevices) mutable {

This looks like it could use the this pointer after it is freed.

if (!weakThis)
    return;

> Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.h:71
> +    enum class ShouldNotify { Yes, No };

: bool