[webkit-reviews] review granted: [Bug 162315] Optimize StringView::CodePoints::Iterator : [Attachment 423976] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 22 19:09:34 PDT 2021
Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 162315: Optimize StringView::CodePoints::Iterator
https://bugs.webkit.org/show_bug.cgi?id=162315
Attachment 423976: Patch
https://bugs.webkit.org/attachment.cgi?id=423976&action=review
--- Comment #11 from Darin Adler <darin at apple.com> ---
Comment on attachment 423976
--> https://bugs.webkit.org/attachment.cgi?id=423976
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=423976&action=review
> Source/WTF/wtf/text/StringView.h:922
> + ASSERT(m_current < m_end);
Seems like we can hoist this assertion out of the if statement.
> Source/WTF/wtf/text/StringView.h:940
> + ASSERT(m_current < m_end);
Ditto.
More information about the webkit-reviews
mailing list