[webkit-reviews] review granted: [Bug 223511] GraphicsContextGLOpenGL should avoid calling into ANGLE MakeCurrent : [Attachment 423866] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 18:59:58 PDT 2021


Kenneth Russell <kbr at google.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 223511: GraphicsContextGLOpenGL should avoid calling into ANGLE MakeCurrent
https://bugs.webkit.org/show_bug.cgi?id=223511

Attachment 423866: Patch

https://bugs.webkit.org/attachment.cgi?id=423866&action=review




--- Comment #13 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 423866
  --> https://bugs.webkit.org/attachment.cgi?id=423866
Patch

Thanks for the update. I didn't understand how the previous code worked because
there's a separate GraphicsContextGL instance for each WebGLRenderingContext,
but this is much clearer. r+

Hopefully the webgl/conformance/extensions/khr-parallel-shader-compile.html
failure on ios-wk2, unrelated to this, has been suppressed.


More information about the webkit-reviews mailing list