[webkit-reviews] review granted: [Bug 223572] Move shader info log functionality from ExtensionsGL to GraphicsContextGL : [Attachment 423872] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 223572: Move shader info log functionality from ExtensionsGL to
GraphicsContextGL
https://bugs.webkit.org/show_bug.cgi?id=223572

Attachment 423872: Patch

https://bugs.webkit.org/attachment.cgi?id=423872&action=review




--- Comment #2 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 423872
  --> https://bugs.webkit.org/attachment.cgi?id=423872
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423872&action=review

One comment about the renaming of this entry point, but r+ once it builds and
passes tests.

> Source/WebCore/ChangeLog:13
> +	   WebGL logic, not ANGLE-specific extensions.

Not sure I agree with this especially as it will relate to moving more
extensions into GraphicsContextGL. glGetTranslatedShaderSourceANGLE is defined
in the GL_ANGLE_translated_shader_source extension and it's useful to track
where these extension entry points are defined. Also, this is used by the
WEBGL_debug_shaders extension (and maybe WebKit's DevTools?) so strictly
speaking isn't part of the core WebGL implementation.

However, I defer to your judgment on the organization.