[webkit-reviews] review granted: [Bug 223551] Web Inspector: rename WebInspectorProxy to WebInspectorUIProxy : [Attachment 423930] Patch v1.4 - for GTK/Win EWS

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 15:51:35 PDT 2021


Devin Rousso <drousso at apple.com> has granted BJ Burg <bburg at apple.com>'s
request for review:
Bug 223551: Web Inspector: rename WebInspectorProxy to WebInspectorUIProxy
https://bugs.webkit.org/show_bug.cgi?id=223551

Attachment 423930: Patch v1.4 - for GTK/Win EWS

https://bugs.webkit.org/attachment.cgi?id=423930&action=review




--- Comment #10 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 423930
  --> https://bugs.webkit.org/attachment.cgi?id=423930
Patch v1.4 - for GTK/Win EWS

rs=me, always wanted to do this :P

View in context: https://bugs.webkit.org/attachment.cgi?id=423804&action=review

>>> Source/WebCore/platform/gtk/po/ar.po:1797
>>> +#: ../../../WebKit2/UIProcess/gtk/WebInspectorUIProxyGtk.cpp:153
>> 
>> Don't worry about these, they don't even exist. They are old comments.
Normally, only POTFILES.in needs to be updated, but WebInspectorProxyGtk.cpp
doesn't have translatable strings anymore, so it's not even listed in
POTFILES.in
> 
> Heh, okay, I'll revert that part. Thanks for the info!

Can we remove these files then (or at least these parts of these files)?


More information about the webkit-reviews mailing list