[webkit-reviews] review granted: [Bug 223435] Move management of RemoteCommandListener from MediaSessionManagerCocoa into NowPlayingManager : [Attachment 423814] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jean-Yves Avenard [:jya]
<jya at apple.com>'s request for review:
Bug 223435: Move management of RemoteCommandListener from
MediaSessionManagerCocoa into NowPlayingManager
https://bugs.webkit.org/show_bug.cgi?id=223435

Attachment 423814: Patch

https://bugs.webkit.org/attachment.cgi?id=423814&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 423814
  --> https://bugs.webkit.org/attachment.cgi?id=423814
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423814&action=review

> Source/WebCore/platform/NowPlayingManager.cpp:65
> +    m_setAsNowPlayingApplication = false;

Do we need both `m_nowPlayingInfo` and `m_setAsNowPlayingApplication` now -
couldn't we clear `m_nowPlayingInfo` here and check `!m_nowPlayingInfo` where
we currently check `m_setAsNowPlayingApplication`?

> Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:390
> +    // FIXME: Eric, why is this call needed? This will reset the seek
information from the one set in setNowPlayingInfo
>      updateSupportedRemoteCommands();

It is needed if we are just switched to a different element, which may have a
different set of supported commands.