[webkit-reviews] review granted: [Bug 223592] [iPadOS] Stale checked item when reopening <select> : [Attachment 423920] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 223592: [iPadOS] Stale checked item when reopening <select>
https://bugs.webkit.org/show_bug.cgi?id=223592

Attachment 423920: Patch

https://bugs.webkit.org/attachment.cgi?id=423920&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 423920
  --> https://bugs.webkit.org/attachment.cgi?id=423920
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423920&action=review

r=mews

> Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:540
> +	   option.isSelected = (optionIndex == index);

Nit - I think you can omit the () here.

>
LayoutTests/fast/forms/ios/form-control-refresh/select/no-stale-checked-items-i
n-select-picker.html:35
> +	       }

Nit - no { } around this if.