[webkit-reviews] review granted: [Bug 216389] No audio output when unplugged wired headset during a call : [Attachment 423890] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 12:58:08 PDT 2021


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 216389: No audio output when unplugged wired headset during a call
https://bugs.webkit.org/show_bug.cgi?id=216389

Attachment 423890: Patch

https://bugs.webkit.org/attachment.cgi?id=423890&action=review




--- Comment #8 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 423890
  --> https://bugs.webkit.org/attachment.cgi?id=423890
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423890&action=review

> Source/WebCore/ChangeLog:17
> +
> +

Nit: two blank lines

> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.h:109
> +private:

Do we need the second `private:`?

> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:76
> +

Nit: extra blank line


More information about the webkit-reviews mailing list