[webkit-reviews] review granted: [Bug 223578] Add logging in IndexedDB to help debug flaky quota tests : [Attachment 423921] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 223578: Add logging in IndexedDB to help debug flaky quota tests
https://bugs.webkit.org/show_bug.cgi?id=223578

Attachment 423921: Patch

https://bugs.webkit.org/attachment.cgi?id=423921&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 423921
  --> https://bugs.webkit.org/attachment.cgi?id=423921
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423921&action=review

> Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:763
> +uint64_t IDBServer::diskUsage(const String& rootDirectory, const
ClientOrigin& origin, bool shouldPrintDetail)

Why isn't this using ShouldPrintUsageDetail enum class?

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1273
> +    auto origin = FileSystem::pathGetFileName(directory);

What is this used for? I don't see it used.