[webkit-reviews] review granted: [Bug 223396] Web Inspector: Port grid overlay drawing to iOS : [Attachment 423842] Patch v1.2 - Move new encoders/decoders to InspectorOverlay.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 12:31:23 PDT 2021


BJ Burg <bburg at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 223396: Web Inspector: Port grid overlay drawing to iOS
https://bugs.webkit.org/show_bug.cgi?id=223396

Attachment 423842: Patch v1.2 - Move new encoders/decoders to
InspectorOverlay.h

https://bugs.webkit.org/attachment.cgi?id=423842&action=review




--- Comment #6 from BJ Burg <bburg at apple.com> ---
Comment on attachment 423842
  --> https://bugs.webkit.org/attachment.cgi?id=423842
Patch v1.2 - Move new encoders/decoders to InspectorOverlay.h

r=me

It's now possible to test the intermediate results of the grid overlay
algorithm (HighlightConfig). If you can think of an area of this code that is
likely to break, we can write a test for it. This would require helpers to dump
the highlight data from WebCore Internals.


More information about the webkit-reviews mailing list