[webkit-reviews] review granted: [Bug 223579] [webkitscmpy] Allow user to force canonicalization for a specific set of commits : [Attachment 423894] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 223579: [webkitscmpy] Allow user to force canonicalization for a specific
set of commits
https://bugs.webkit.org/show_bug.cgi?id=223579

Attachment 423894: Patch

https://bugs.webkit.org/attachment.cgi?id=423894&action=review




--- Comment #3 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 423894
  --> https://bugs.webkit.org/attachment.cgi?id=423894
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423894&action=review

>
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/canonicalize/__init__.p
y:80
> +	   difference = args.number

difference should be replaced by something which indicate the purpose, e.g.:
num_commits_to_canonicalize

>
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/canonicalize/__init__.p
y:81
> +	   if not args.number:

better to use the above variable here in in condition, e.g.: 'if
difference'/'if num_commits_to_canonicalize'

>
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/canonicalize_unittest.py:2
13
> +	       self.assertEqual(

can consider formatting it in one line.