[webkit-reviews] review granted: [Bug 223475] [LayoutTests] Convert http/tests/multipart convert PHP to Python : [Attachment 423643] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 09:39:12 PDT 2021


Jonathan Bedard <jbedard at apple.com> has granted Chris Gambrell
<cgambrell at apple.com>'s request for review:
Bug 223475: [LayoutTests] Convert http/tests/multipart convert PHP to Python
https://bugs.webkit.org/show_bug.cgi?id=223475

Attachment 423643: Patch

https://bugs.webkit.org/attachment.cgi?id=423643&action=review




--- Comment #3 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 423643
  --> https://bugs.webkit.org/attachment.cgi?id=423643
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423643&action=review

> LayoutTests/http/tests/multipart/multipart-html.py:13
> +    '{}\n'

You used f-strings in another patch, might be a good choice here too

> LayoutTests/http/tests/multipart/multipart-replace-non-html-content.py:13
> +    '{}\n'

Might consider f-string here as well


More information about the webkit-reviews mailing list