[webkit-reviews] review granted: [Bug 223541] [LayoutTests] Convert http/tests/resourceLoadStatistics convert PHP to Python : [Attachment 423879] Patch

Mon Mar 22 08:53:05 PDT 2021

Alex Christensen <achristensen at apple.com> has granted Chris Gambrell
<cgambrell at apple.com>'s request for review:
Bug 223541: [LayoutTests] Convert http/tests/resourceLoadStatistics convert PHP
to Python
https://bugs.webkit.org/show_bug.cgi?id=223541

Attachment 423879: Patch

https://bugs.webkit.org/attachment.cgi?id=423879&action=review

--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 423879
  --> https://bugs.webkit.org/attachment.cgi?id=423879
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423879&action=review

>
LayoutTests/http/tests/resourceLoadStatistics/do-not-switch-session-on-navigati
on-to-prevalent-without-interaction.py:6
> +    'Cache-Control: no-store\r\n'

Doesn't python support """multi-line string literals"""?

>
LayoutTests/http/tests/resourceLoadStatistics/switch-session-on-navigation-to-p
revalent-with-interaction.py:10
> +    '<head>\n'

ditto