[webkit-reviews] review granted: [Bug 222889] [GStreamer] CaptureDevice monitoring is not implemented : [Attachment 423829] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 222889: [GStreamer] CaptureDevice monitoring is not implemented
https://bugs.webkit.org/show_bug.cgi?id=222889

Attachment 423829: Patch

https://bugs.webkit.org/attachment.cgi?id=423829&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 423829
  --> https://bugs.webkit.org/attachment.cgi?id=423829
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423829&action=review

>
Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp
:155
> +	       break;

Nit: you could avoid this break.

>
Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp
:158
> +	       break;

And maybe this one.