[webkit-reviews] review granted: [Bug 223564] [GPUP] RemoteAudioSession calls into AVAudioSession when GPUP is enabled, causing hangs : [Attachment 423835] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 21 20:07:26 PDT 2021
Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 223564: [GPUP] RemoteAudioSession calls into AVAudioSession when GPUP is
enabled, causing hangs
https://bugs.webkit.org/show_bug.cgi?id=223564
Attachment 423835: Patch
https://bugs.webkit.org/attachment.cgi?id=423835&action=review
--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 423835
--> https://bugs.webkit.org/attachment.cgi?id=423835
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=423835&action=review
> Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:102
> - m_interruptionObserverHelper = adoptNS([[WebInterruptionObserverHelper
alloc] initWithCallback:session]);
> + m_interruptionObserverHelper = [[WebInterruptionObserverHelper alloc]
initWithCallback:this];
Did you mean to drop the `adoptNS`?
More information about the webkit-reviews
mailing list