[webkit-reviews] review denied: [Bug 223396] Web Inspector: Port grid overlay drawing to iOS : [Attachment 423788] Patch v1.1 - Add FloatLine.h to Headers.cmake

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Patrick Angle <pangle at apple.com>'s
request for review:
Bug 223396: Web Inspector: Port grid overlay drawing to iOS
https://bugs.webkit.org/show_bug.cgi?id=223396

Attachment 423788: Patch v1.1 - Add FloatLine.h to Headers.cmake

https://bugs.webkit.org/attachment.cgi?id=423788&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 423788
  --> https://bugs.webkit.org/attachment.cgi?id=423788
Patch v1.1 - Add FloatLine.h to Headers.cmake

View in context: https://bugs.webkit.org/attachment.cgi?id=423788&action=review

> Source/WebKit/Shared/WebCoreArgumentCoders.h:500
> +template<> struct
ArgumentCoder<WebCore::InspectorOverlay::Highlight::GridHighlightOverlay> {
> +    static void encode(Encoder&, const
WebCore::InspectorOverlay::Highlight::GridHighlightOverlay&);
> +    static WARN_UNUSED_RETURN bool decode(Decoder&,
WebCore::InspectorOverlay::Highlight::GridHighlightOverlay&);
> +};
> +
> +template<> struct
ArgumentCoder<WebCore::InspectorOverlay::Highlight::GridHighlightOverlay::Label
> {
> +    static void encode(Encoder&, const
WebCore::InspectorOverlay::Highlight::GridHighlightOverlay::Label&);
> +    static WARN_UNUSED_RETURN bool decode(Decoder&,
WebCore::InspectorOverlay::Highlight::GridHighlightOverlay::Label&);
> +};
> +
> +template<> struct
ArgumentCoder<WebCore::InspectorOverlay::Highlight::GridHighlightOverlay::Area>
{
> +    static void encode(Encoder&, const
WebCore::InspectorOverlay::Highlight::GridHighlightOverlay::Area&);
> +    static WARN_UNUSED_RETURN bool decode(Decoder&,
WebCore::InspectorOverlay::Highlight::GridHighlightOverlay::Area&);
> +};

Rather than adding new coders here (which we are tying to avoid), please
instead add the coders to the files these types are defined in using the
generic coding (e.g. template<class Encoder>/template<class Decoder>) pattern.