[webkit-reviews] review granted: [Bug 223553] [JSC] Intl.Locale should not assume is8Bit : [Attachment 423808] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 20 17:01:06 PDT 2021

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 223553: [JSC] Intl.Locale should not assume is8Bit

Attachment 423808: Patch


--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 423808
  --> https://bugs.webkit.org/attachment.cgi?id=423808

View in context: https://bugs.webkit.org/attachment.cgi?id=423808&action=review

r=me. This comes as a shock to me, since we have in fact verified all the
characters of these strings by this point. :(

> Source/JavaScriptCore/runtime/IntlLocale.cpp:180
> +    Vector<char, 32> rawValue;
> +    rawValue.resize(value.length() + 1);

Is this different from using the constructor param?

More information about the webkit-reviews mailing list