[webkit-reviews] review granted: [Bug 223071] Implement AbortSignal.abort() : [Attachment 423772] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 19 18:27:01 PDT 2021

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 223071: Implement AbortSignal.abort()

Attachment 423772: Patch


--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 423772
  --> https://bugs.webkit.org/attachment.cgi?id=423772

View in context: https://bugs.webkit.org/attachment.cgi?id=423772&action=review

> Source/WebCore/dom/AbortSignal.h:45
> +    static Ref<AbortSignal> createAborted(ScriptExecutionContext&);

Why not name this abort to match the DOM public API?

More information about the webkit-reviews mailing list