[webkit-reviews] review granted: [Bug 223510] Cannot login to microsoftonline.com without allowing storage access : [Attachment 423761] Patch

[bugzilla-daemon at webkit.org]

John Wilander <wilander at apple.com> has granted katherine_cheney at apple.com's
request for review:
Bug 223510: Cannot login to microsoftonline.com without allowing storage access
https://bugs.webkit.org/show_bug.cgi?id=223510

Attachment 423761: Patch

https://bugs.webkit.org/attachment.cgi?id=423761&action=review




--- Comment #7 from John Wilander <wilander at apple.com> ---
Comment on attachment 423761
  --> https://bugs.webkit.org/attachment.cgi?id=423761
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423761&action=review

r=me with comments.

> Source/WebCore/ChangeLog:15
> +	   2. Allow login even if the user denies storage access. Previously we

I wouldn't say "allow login" since the browser doesn't decide that. I'd say
"don't cancel the click" instead.

> Source/WebKit/ChangeLog:10
> +	   allow login on sites even if the user denies storage access. See

Ditto on allowing login.

> Source/WebCore/dom/Element.cpp:400
> +	   isParentProcessAFullWebBrowser = true;

This can be just isParentProcessAFullWebBrowser = MacApplication::isSafari().

> Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1962
> +    auto* page = m_frame->page();

I looked and other functions use m_frame directly too so should be fine.