[webkit-reviews] review granted: [Bug 223523] [GPUP] Add a "timestamp" field to struct RemoteMediaPlayerState : [Attachment 423774] Fix test failures and update TestExpectations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 19 14:50:06 PDT 2021


Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 223523: [GPUP] Add a "timestamp" field to struct RemoteMediaPlayerState
https://bugs.webkit.org/show_bug.cgi?id=223523

Attachment 423774: Fix test failures and update TestExpectations

https://bugs.webkit.org/attachment.cgi?id=423774&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 423774
  --> https://bugs.webkit.org/attachment.cgi?id=423774
Fix test failures and update TestExpectations

View in context: https://bugs.webkit.org/attachment.cgi?id=423774&action=review

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:814
> +    m_cachedState.timestamp = WallTime::now();

Nit: I think 'wallTime' might be more clear than 'timestamp'


More information about the webkit-reviews mailing list